Skip to content

Conversation

@mf2199
Copy link
Contributor

@mf2199 mf2199 commented Sep 11, 2020

Splitting #482 into two stages: (1) Refactoring spanner_dbapi into google.cloud.spanner_dbapi and (2) moving/renaming django_spanner folder as necessary. These changes represent the first stage that as of right now builds error-free.

Change list:

  1. spanner_dbapi folder moved inside google/cloud/;
  2. Invalidated references updated to reflect the above changes;
  3. Relevant updates to noxfile.py.

No changes were made to the docs files, which are intended to be updated in a separate PR.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2020
@mf2199 mf2199 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Sep 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2020
@mf2199 mf2199 changed the title chore: [alt] Code refactoring to follow common Google API scheme --- tryout! chore: Code refactoring to follow common Google API scheme - Stage I Sep 14, 2020
@mf2199 mf2199 requested a review from c24t September 14, 2020 06:50
@mf2199 mf2199 marked this pull request as ready for review September 14, 2020 06:50
@c24t c24t merged commit 59eb432 into googleapis:master Sep 14, 2020
@c24t c24t deleted the refactor-alt branch September 14, 2020 18:51
@c24t c24t restored the refactor-alt branch September 14, 2020 18:51
@IlyaFaer IlyaFaer deleted the refactor-alt branch December 16, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants