Skip to content

Fix test failure related to pycares #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SukramJ wants to merge 4 commits into from
Closed

Fix test failure related to pycares #230

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d456ba7
Fix test failure
SukramJ Dec 17, 2025
4ce046c
Update setup.py
SukramJ Dec 17, 2025
bb1b20d
requirements_test.txt aktualisieren
SukramJ Dec 17, 2025
969e8f4
Revert "requirements_test.txt aktualisieren"
SukramJ Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ SQLAlchemy==2.0.41
paho-mqtt==2.1.0

numpy==2.3.2

pycares<5.0.0 # Pin to 4.x until aiodns supports pycares 5.0 breaking changes

@MatthewFlamm MatthewFlamm Dec 17, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generate action should handle this if the other fix is correct.

Suggested change
pycares<5.0.0 # Pin to 4.x until aiodns supports pycares 5.0 breaking changes

@MatthewFlamm MatthewFlamm Dec 17, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm this is weird that it now fails.

@MatthewFlamm MatthewFlamm Dec 17, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether the tests in the CI here do not get updated library versions after generating the new package.

@MatthewFlamm MatthewFlamm Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether the tests in the CI here do not get updated library versions after generating the new package.

There does seem to be some bug here in the CI for pytest-homeassistant-custom-component, which is why manually adding the pin appeared to work, however, this is not a true fix.

After downloading the artifact, the pycares pin does not show up in the requirements file because of #230 (comment)

9 changes: 8 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@
]
with open("requirements_test.txt","r") as f:
for line in f:
if "txt" not in line and "#" not in line:
line = line.strip()
# Skip empty lines and lines that reference other files
if not line or line.startswith("-") or ".txt" in line:
continue
# Strip inline comments but keep the requirement
if "#" in line:
line = line.split("#")[0].strip()
if line:
requirements.append(line)

with open("version", "r") as f:
Expand Down