Fix test failure related to pycares#230
Conversation
|
|
||
| numpy==2.3.2 | ||
|
|
||
| pycares<5.0.0 # Pin to 4.x until aiodns supports pycares 5.0 breaking changes |
There was a problem hiding this comment.
The generate action should handle this if the other fix is correct.
| pycares<5.0.0 # Pin to 4.x until aiodns supports pycares 5.0 breaking changes |
There was a problem hiding this comment.
Hmmm this is weird that it now fails.
There was a problem hiding this comment.
I'm wondering whether the tests in the CI here do not get updated library versions after generating the new package.
There was a problem hiding this comment.
I'm wondering whether the tests in the CI here do not get updated library versions after generating the new package.
There does seem to be some bug here in the CI for pytest-homeassistant-custom-component, which is why manually adding the pin appeared to work, however, this is not a true fix.
After downloading the artifact, the pycares pin does not show up in the requirements file because of #230 (comment)
Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
|
The pin in homeassistant is in this file Note that this PR removes the constraints reference, which cannot be used in setup.py This sort of sub-dependency constraint in homeassistant will be really hard for this package to control.... |
|
I don't see a clean way to handle this in this package. Either downstream packages need to pin it, or wait for aio-libs/aiodns#218, or similar, to be merged. I will leave this open in case there are any other ideas to fix. |
For me this was the temporary fix! |
This reverts commit bb1b20d.
|
I think this is no longer needed. |
2 participants
No description provided.