Skip to content

Convert dew point units to match temperature units #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthewFlamm merged 5 commits into from
Jul 3, 2023
Merged

Convert dew point units to match temperature units #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e73eff4
Adjust dew point units to match temperature units when necessary
lymanepp Jul 2, 2023
c476239
Add type checking
lymanepp Jul 2, 2023
800e904
Minor cleanup
lymanepp Jul 2, 2023
cb3acf1
Minor cleanup
lymanepp Jul 2, 2023
badb92e
Minor cleanup
lymanepp Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pynws/simple_nws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,17 @@ def _convert_forecast(
if (value := forecast_entry.get("temperature")) is not None:
forecast_entry["temperature"] = int(value)

temp_unit = forecast_entry.get("temperatureUnit")

for key in ("probabilityOfPrecipitation", "dewpoint", "relativeHumidity"):
if (value := SimpleNWS.extract_value(forecast_entry, key)) is not None:
forecast_entry[key] = int(value[0])
extracted = SimpleNWS.extract_value(forecast_entry, key)
if isinstance(extracted, tuple):
value, value_unit = extracted
if value_unit.endswith("degC") and temp_unit == "F":
value = round(float(value) * 1.8 + 32, 0)
elif value_unit.endswith("degF") and temp_unit == "C":
value = round((float(value) - 32) / 1.8, 0)
forecast_entry[key] = int(value)

if forecast_entry.get("icon"):
time, weather = parse_icon(forecast_entry["icon"])
Expand Down
4 changes: 2 additions & 2 deletions tests/test_simple_nws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ async def test_nws_forecast(aiohttp_client, event_loop, mock_urls):

assert forecast[0]["temperature"] == 41
assert forecast[0]["probabilityOfPrecipitation"] == 20
assert forecast[0]["dewpoint"] == 5
assert forecast[0]["dewpoint"] == 41
assert forecast[0]["relativeHumidity"] == 63

assert forecast[0]["iconWeather"][0][0] == "Thunderstorm (high cloud cover)"
Expand Down Expand Up @@ -200,7 +200,7 @@ async def test_nws_forecast_hourly(aiohttp_client, event_loop, mock_urls):

assert forecast[0]["temperature"] == 78
assert forecast[0]["probabilityOfPrecipitation"] == 20
assert forecast[0]["dewpoint"] == 5
assert forecast[0]["dewpoint"] == 41
assert forecast[0]["relativeHumidity"] == 63


Expand Down