Convert dew point units to match temperature units#119
Merged
Conversation
Owner
|
This LGTM. Thanks! This project doesn't do a very good job with integers vs. float, particularly when there are conversions. This PR is consistent with the current code though. |
MatthewFlamm
approved these changes
Jul 3, 2023
Owner
|
Unless there is anything else you intend to add, I can make a release. |
Collaborator
Author
|
I don't have any other changes. Ready for a release that I can use to update the HA PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the dew point units don't match the temperature:
Ideally, the pynws API would use Celsius for all response values. But some of the NWS responses contain values in strings such as:
Showers and thunderstorms likely. Mostly sunny. High near 98, with temperatures falling to around 95 in the afternoon. Heat index values as high as 106. Southwest wind 5 to 10 mph. Chance of precipitation is 60%. New rainfall amounts less than a tenth of an inch possible.So making all degree units in a forecast response match the temperature seems like the least-bad approach.