Fix race conditions when establishing SSH connections#371
Fix race conditions when establishing SSH connections#371giffels merged 6 commits intoMatterMiners:masterfrom
Conversation
|
Looks like the coverage upload of the unittests got broken by codecov/codecov-action v5.4.1. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 55 55
Lines 2266 2271 +5
=======================================
+ Hits 2242 2247 +5
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed again! |
|
I have added a test case, that explicitly tests the race condition in #369 and checks that no new connection is created by the second attempt. |
|
Nice, thanks! I wasn't sure how to test this, your test looks very good. |
giffels
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot for providing a fix. Just decide whether you like to go for a namedtuple or stay with a tuple.
Co-authored-by: Manuel Giffels <giffels@gmail.com>
This PR addresses two race conditions around SSH connections. Major changes include:
This fixes using an SSH connection before any bound has been created (#369) as well as using a bound of a previous connection. Closes #370.