Skip to content

Fix race condition during ssh session probe#370

Closed
giffels wants to merge 2 commits intoMatterMiners:masterfrom
giffels:fix/ssh-session-probe
Closed

Fix race condition during ssh session probe#370
giffels wants to merge 2 commits intoMatterMiners:masterfrom
giffels:fix/ssh-session-probe

Conversation

@giffels
Copy link
Member

@giffels giffels commented Apr 14, 2025

Fixes #369.

@giffels giffels added the bug Something isn't working label Apr 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (58b66e0) to head (7428199).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          55       55           
  Lines        2266     2270    +4     
=======================================
+ Hits         2242     2246    +4     
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxfischer2781
Copy link
Member

I think this has a race condition where the new connection already exists but the old bound is still there. (Which is a race we had before, too. 😬 )

There are some tagalong change to my recommended fix, I'll try and create a PR for all that this evening.

@giffels giffels force-pushed the fix/ssh-session-probe branch from b22a271 to 7428199 Compare April 15, 2025 11:11
@giffels
Copy link
Member Author

giffels commented Apr 16, 2025

Superseded by #371.

@giffels giffels closed this Apr 16, 2025
@giffels giffels deleted the fix/ssh-session-probe branch April 16, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash after C/T restart

3 participants