catch not known attributes in ClearAttributes and SetAttributes #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmatera ok - after this passes CI let's merge and I will rebase off of this. |
|
@mmatera If you have it, what is the exact error that occurs in FeynCalc? |
|
This PR would suggest that Feyncalc has a bug which is hard to believe. So what changed in Mathematica? |
FeynCalc has a typo, that tries to Clear an attribute that do not exist. This patch just catch the exception. Regarding the bug, it just tries to set ReadProtected attribute to some symbols, but there is a typo (something like ReadProtetced), that in WMA does not have any consequence, but here kills the kernel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rocky, please before merging #607, add this patch, to a bug that came up trying to load FeynCalc