Skip to content

Update 'attributes' for current standards #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2022
Merged

Update 'attributes' for current standards #607

merged 1 commit into from
Nov 11, 2022

Conversation

rocky
Copy link
Member

@rocky rocky commented Nov 11, 2022 •
edited by gitpod-io bot
Loading

mathics.builtin.attributes:

  • def apply( -> def eval(
  • Add WMA links
  • Class names ordered alphabetically
  • Hard breaks in docstring removed
  • Some incorrect references to "leaves" changed to "attributes"

mathics.core.attributes:

  • Add short comments above flag value

@rocky
Copy link
Member Author

rocky commented Nov 11, 2022 •
edited
Loading

In getting up to speed and to start to understand and appreciate #601 #602 it was helpful for me to update the attribute code. Most of it is just getting to current standards.

@mmatera mmatera mentioned this pull request Nov 11, 2022
Merged
@rocky
Update 'attributes' for current standards
6fda837 
`mathics.builtin.attributes`:

* apply -> eval
* Add WMA links add
* Class names ordered alphabetically
* Hard breaks in docstring removed
* Some incorrect references to "leaves" changed to "attributes"

`mathics.core.attributes`:

* Add short comments above flag value
@rocky rocky force-pushed the update-attribute-for-current-standards branch from d9a3761 to 6fda837 Compare November 11, 2022 13:48
mmatera
mmatera approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 3528e0d into master Nov 11, 2022
@rocky rocky deleted the update-attribute-for-current-standards branch November 11, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmatera mmatera mmatera approved these changes

@TiagoCavalcante TiagoCavalcante Awaiting requested review from TiagoCavalcante

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rocky @mmatera