Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow cross region PrivateLink connections #30897

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Allow cross region PrivateLink connections #30897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3cbbeb
[WIP] Allow cross region PrivateLink connections
bobbyiliev Dec 23, 2024
fd57c3a
Fix formatting error
bobbyiliev Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/sql/src/plan/statement/ddl/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,17 +262,22 @@ impl ConnectionOptionExtracted {
let mut duplicate_azs: BTreeSet<String> = BTreeSet::new();
// Validate each AZ is supported
for connection_az in &connection.availability_zones {
if unique_azs.contains(connection_az) {
duplicate_azs.insert(connection_az.to_string());
} else {
unique_azs.insert(connection_az.to_string());
}
if !supported_azs.contains(connection_az) {
if !connection_az
.chars()
.all(|c| c.is_ascii_alphanumeric() || c == '-')
|| !connection_az.contains("-az")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we could tighten this up to be more precise. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#az-ids has more details on the structure

the most legit solution would be to automatically pull every AZ ID from the partition we're operating in during our Pulumi run and then plumbing it 20 layers deep to here... in practice I think just ensuring we're following the structure in the doc above is sufficient

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and if we pull out some logic to validate the ids, we should add a quick unit test)

{
return Err(PlanError::InvalidPrivatelinkAvailabilityZone {
name: connection_az.to_string(),
supported_azs,
});
}

if unique_azs.contains(connection_az) {
duplicate_azs.insert(connection_az.to_string());
} else {
unique_azs.insert(connection_az.to_string());
}
}
if duplicate_azs.len() > 0 {
return Err(PlanError::DuplicatePrivatelinkAvailabilityZone {
Expand Down
Loading