Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unnecessary .typ() call from keys_with_input_keys #30878

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Eliminate unnecessary .typ() call from keys_with_input_keys #30878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/expr/src/relation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,13 +1107,18 @@ impl MirRelationExpr {
{
if first_id == second_id {
result.extend(
inputs[0].typ().keys.drain(..).filter(|key| {
key.iter().all(|c| {
outputs.get(*c) == Some(c)
&& base_projection.get(*c)
== Some(c)
})
}),
input_keys
.next()
.unwrap()
.clone()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than .clone()ing up front, you can put a .cloned() at the very end, so we only copy the ones we want to keep.

Suggested change
.clone()

.into_iter()
.filter(|key| {
key.iter().all(|c| {
outputs.get(*c) == Some(c)
&& base_projection.get(*c)
== Some(c)
})
}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}),
})
.cloned(),

);
}
}
Expand Down
Loading