Eliminate unnecessary .typ() call from keys_with_input_keys
#30878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
added
A-CLUSTER
This was referenced Dec 20, 2024
mgree
reviewed
Dec 23, 2024
| input_keys | ||
| .next() | ||
| .unwrap() | ||
| .clone() |
There was a problem hiding this comment.
Rather than .clone()ing up front, you can put a .cloned() at the very end, so we only copy the ones we want to keep.
Suggested change
| .clone() |
| && base_projection.get(*c) | ||
| == Some(c) | ||
| }) | ||
| }), |
There was a problem hiding this comment.
Suggested change
| }), | |
| }) | |
| .cloned(), |
mgree
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the whole point of
keys_with_input_keysthat we already have the input key available, so we don't need to call.typ()to get the key of an input. So, this PR substitutes thetypcall withinput_keys.next().unwrap()(which is a pattern that already occurs several times inkeys_with_input_keys).Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.