expr: add protobuf support for VariadicFunc (complete)
#11902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexandrov
added
A-compute
wangandi
approved these changes
Apr 19, 2022
Add a note explaining why we need explicit `Arbitrary` implementations for most `~Func` enums and when we can revert back to the derive-based variants.
aalexandrov
force-pushed
the
protobuf_variadic_func
branch
from
56eba1e
to
9ef3ce9
Compare
aalexandrov
force-pushed
the
protobuf_variadic_func
branch
from
9ef3ce9
to
86f2a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftovers from #11823.
Motivation
This PR adds a known-desirable feature.
Closes #11749.
Tips for reviewer
I only need one from @wangandi or @lluki to take a look. The commits (in append order) do the following:
Arbitraryimplementations for most~Funcenums.VariadicFuncvariants from the various traits and the*.protofile.ProtoVariadicFuncdefinition so the most common cases receive a 1-byte tag.any_fixed_offset.Testing
Tested with
Release notes
N/A