expr: stub protobuf support for VariadicFunc
#11823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexandrov
added
C-feature
aalexandrov
changed the title
VariadicFunc (incomplete)VariadicFunc
aalexandrov
force-pushed
the
protobuf_variadic_func
branch
4 times, most recently
from
91bb13c
to
2f414c8
Compare
wangandi
approved these changes
Apr 15, 2022
- Add `ProtoVariadicFunc` to `func.proto`. Variants that are not properly modeled as protobuf yet are prefixed with an `// unsupported:` comment. - Implement `From<&VariadicFunc> for ProtoVariadicFunc` in `func.rs`. Arms that are not yet supported have a `todo!()` placeholder. - Implement `TryFrom<ProtoVariadicFunc> for VariadicFunc` in `func.rs`. Arms that are not yet supported have a `todo!()` placeholder.
aalexandrov
force-pushed
the
protobuf_variadic_func
branch
from
2f414c8
to
b9a0f89
Compare
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds partial protobuf support for
VariadicFunc.Motivation
First step towards resolving MaterializeInc/database-issues#3432.
Tips for reviewer
The first commit partially implements
ArbitraryforVariadicFunc.VariadicFunctowards closing MaterializeInc/database-issues#3432.The third commit changes things as follows:
ProtoVariadicFunctofunc.proto. Variants that are not properly modeled as protobuf yet are prefixed with an// unsupported:comment.From<&VariadicFunc> for ProtoVariadicFuncinfunc.rs. Arms that are not yet supported have atodo!()placeholder.TryFrom<ProtoVariadicFunc> for VariadicFuncinfunc.rs. Arms that are not yet supported have atodo!()placeholder.Testing
Test coverage has been added for the variants that are already supported. As we add more variants, we will need to expand the custom
Arbitraryimplementation forVariadicFuncto keep this invariant.Release notes
N/A
Footnotes
https://github.com/AltSysrq/proptest/issues/152 ↩