Add real Ad blocking using custom ad filters #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derived from uBlock Origin: uBlockOrigin/uAssets#17495
- if tray minimize is enabled quit hides the app to tray
- mpris important property (maybe needed sometime)
4 tasks
thanasistrisp
force-pushed
the
adblocking
branch
from
b37678d to
b2e68f5
Compare
… and applied some formatting
Mastermindzh
approved these changes
Apr 21, 2023
Ok thanks, also merge #217 if you can to fix some bugs relevant to tray (electron update basically). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In comparison with #214, now we have real adblocking and it is multiplatform (it does not require mpris service, which is available only at Linux). Ads are not loaded at all and videos/lyrics are also available even in free accounts. Hifi and master quality is not possible as they are server-sided.
Thanks to this issue, the result is exactly the same if we add the following custom filter to uBlockOrigin in browser:
Also restart behavior fixed when minimize on closed is enabled and added support for mpris:trackid property.