[BUG] Update electron to 24.1.2 for fixing tray single click bug #217
Conversation
thanasistrisp
changed the title
thanasistrisp
changed the title
|
Hey @thanasistrisp, Versions that are built using v20+ electron versions only display a white screen after launch. That is the exact same reason why the original code (that you restore) had been removed. If you can get it working without a white screen after building then please let me know 😄 |
@Mastermindzh, I did not notice any problem with white screen else if I had the problem I would not open pull request. It just needs to explicitly say |
|
I'll try again. I take it the change to the adblock URL is absolutely needed before a new release since it's blocking the settings? (I don't have a tidal account with ads) |
Just try npm install before run. And clone my repository exactly as I have it. Latest commit is not so urgent, but is shows some more account settings that the previous filter blocked. (I hope I did not miss anything as I tried to resolved merge conflict from previous commits of bots dependencies) |
|
Alright, that seems to have done the trick. Didn't know the default changed. You just need the following changes to make it all work: Other than that we can merge these changes too and release a version 5 this weekend 😄 |
|
@thanasistrisp , I can do it myself as well if you want, I don't mind 😄 (you gave me contributor on the fork anyway) |
Do it yes. |
…1ac3f20e6c8576da25c1dd4616f859 [Snyk] Upgrade sass from 1.58.3 to 1.60.0
this is a common behavior of most electron apps
derived from uBlock Origin: uBlockOrigin/uAssets#17495
- if tray minimize is enabled quit hides the app to tray
- mpris important property (maybe needed sometime)
… and applied some formatting
Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.2 and updates ancestor dependency [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder). These dependencies need to be updated together. Updates `minimatch` from 3.0.4 to 3.1.2 - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) Updates `electron-builder` from 23.5.1 to 24.2.1 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/v24.2.1/packages/electron-builder) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect - dependency-name: electron-builder dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Mastermindzh
force-pushed
the
electron-tray
branch
from
a083ea9 to
efc9116
Compare
By updating electron and making some small fixes, single tray icon click is finally working. It was an upstream bug that fixed only in versions 22.x (see here). It should now be fixed for most desktop environments.
Now, when pressing tray icon, the window shows or hides appropriately. Previously, I could not have single left click, as it showed the menu (like pressing right click). I use arch Linux with KDE.
Also, I updated some dependencies without breaking changes.Resolved merge conflict by reverting to main dependencies except of electron version only.