Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/metadata-attstmt-alg-check #251

Merged
merged 4 commits into from
Aug 15, 2022
Merged

fix/metadata-attstmt-alg-check #251

merged 4 commits into from
Aug 15, 2022

Conversation

MasterKale
Copy link
Owner

This PR adds in an attestation statement algorithm check against values reported in authenticatorGetInfo in metadata. The following FIDO Conformance Tools v1.7.2 test should now pass:

F-16 Send "packed" ServerAuthenticatorAttestationResponse with attStmt.alg does not match Alg in metadata statement, and check that server returns an error

Screen Shot 2022-08-14 at 12 14 23 PM

Fixes #248

@MasterKale MasterKale mentioned this pull request Aug 14, 2022
Closed
@MasterKale MasterKale added this to the v5.4.4 milestone Aug 15, 2022
@MasterKale MasterKale merged commit 3b14ba5 into master Aug 15, 2022
@MasterKale MasterKale deleted the fix/metadata-attstmt-alg-check branch August 15, 2022 05:57
@MasterKale MasterKale added the package:server @simplewebauthn/server label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:server @simplewebauthn/server
Projects
None yet
Milestone
v5.4.4
Development

Successfully merging this pull request may close these issues.

Library does not check algorithm in specific case.
1 participant
@MasterKale