Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library does not check algorithm in specific case. #248

Closed
lightpurple opened this issue Aug 12, 2022 · 2 comments · Fixed by #251
Closed

Library does not check algorithm in specific case. #248

lightpurple opened this issue Aug 12, 2022 · 2 comments · Fixed by #251

Comments

@lightpurple
Copy link

We developed Server using simpleWebAuthn(5.4.2) library. Test by FIDO Conformance Tools 1.7.2

And I found that library no algorithm check when the fmt value is 'packed' and the x5c value exists.

So there are successful cases even if the algorithm value not allowed in the fido2. ex) alg = -42

image

Can you give some suggestions to solve this?

@MasterKale
Copy link
Owner

Thanks for reporting this, I have a fix for it out in #251. I'll merge it later today and release this with the fix for #247.

@MasterKale
Copy link
Owner

The fix for this is now available in @simplewebauthn/[email protected].

@lightpurple lightpurple changed the title Do not check algorithm in specific case. Library Does not check algorithm in specific case. Aug 21, 2022
@lightpurple lightpurple changed the title Library Does not check algorithm in specific case. Library does not check algorithm in specific case. Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants