Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor GitHubIssueSearch and remove redundant files #1377

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

MartinWitt
Copy link
Owner

No description provided.

Refactored GitHubIssueSearch to simplify the methods, improve efficiency and readability, and added error handling for issue searching. Removed redundant classes and interfaces related to GitHub issues and pull requests, placed the remaining classes under the 'github' package. Reimplemented the Issue finder logic in the PeriodicSummary class for better fault tolerance.
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs must be titled according to our semantic naming policy: <type>(<scope>): <short summary>

Type must be one of the following:

  • build
  • ci
  • chore
  • docs
  • feat
  • fix
  • refactor

@MartinWitt MartinWitt changed the title feat/githubPackages refactor: Refactor GitHubIssueSearch and remove redundant files Dec 19, 2023
Copy link

gitstream-cm bot commented Dec 19, 2023

This PR is 41.208791208791204% new code.

Copy link
Contributor

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Field may be 'final' 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@MartinWitt MartinWitt merged commit 202b20e into master Dec 19, 2023
7 of 11 checks passed
@MartinWitt MartinWitt deleted the feat/githubPackages branch December 19, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant