Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactopr: Refactor various classes to use GitProject instead of Project #1376

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

MartinWitt
Copy link
Owner

Several classes have been refactored to replace the usage of the old Project class with the new GitProject class. This includes changes in fields, methods, and parameters, and affects multiple classes within the github-bot module. The changes bring more clarity and specificity to the naming and understanding of the project context.

Several classes have been refactored to replace the usage of the old Project class with the new GitProject class. This includes changes in fields, methods, and parameters, and affects multiple classes within the github-bot module. The changes bring more clarity and specificity to the naming and understanding of the project context.
gitstream-cm[bot]
gitstream-cm bot previously requested changes Dec 19, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs must be titled according to our semantic naming policy: <type>(<scope>): <short summary>

Type must be one of the following:

  • build
  • ci
  • chore
  • docs
  • feat
  • fix

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a TODO statement. Please check to see if they should be removed.

@MartinWitt MartinWitt changed the title style: Refactor various classes to use GitProject instead of Project refactopr: Refactor various classes to use GitProject instead of Project Dec 19, 2023
Copy link

gitstream-cm bot commented Dec 19, 2023

 /:\ gitStream DRY RUN 

enforce_pr_title/enforce_pr_title

• request change and add this comment: All PRs must be titled according to our semantic naming policy: (): `

Type must be one of the following:

  • build
  • ci
  • chore
  • docs
  • feat
  • fix
  • refactor
    `

label_deleted_files/label_deleted_files

• add label deleted-files with color #DF9C04

percent_new_code/percent_new_code

• add comment This PR is 42.650918635170605% new code.

provide_estimated_time_to_review/estimated_time_to_review

• add label 30 min review with color b60205

review_todo_comments/review_todo_comments

• request change and add this comment: This PR contains a TODO statement. Please check to see if they should be removed.

To activate these actions - merge this PR into the main branch


Learn more on the gitStream Docs
See your automations on the gitStream app
Create new rules on the gitSteam playground

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@gitstream-cm gitstream-cm bot dismissed their stale review December 19, 2023 15:42

Review resolved

@MartinWitt MartinWitt merged commit 89053a7 into master Dec 19, 2023
10 checks passed
@MartinWitt MartinWitt deleted the feat/gitProjects branch December 19, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant