[1.1.x] Clear retracted status when homing the Z axis#9390
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom Feb 2, 2018
Merged
[1.1.x] Clear retracted status when homing the Z axis#9390thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
Member
|
Looks good, though I think the retract state should be cleared on all |
Contributor
Author
|
I thought about that, but I thought that could be problematic with skipped
step detection on X and Y in the event that it decided to re-home X and Y
while the filament is retracted and possibly hopping. As such, I figured
that only clearing the retracted status when Z is homed would be the safest
option.
|
Member
|
Good point. |
This was referenced Aug 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9384 repackaged for 1.1.x