[WIP] Printer information menu

[birkett]

Adds an "About Printer" menu entry in the main menu, to show basic information about the printer and firmware configuration.

Currently untested, and incomplete.

TODO:
Add string translations for languages other than English

[jbrazio]

This is a good idea.
Don't forget to add print job information is the user has the option enabled in the config.

[jbrazio]

I just find the board name an overkill, maybe it would suffice to show the board #define ? It would be less one additional list to maintain. Or if would like to keep the pretty name, maybe the name #define would go inside each pin file having a default #define of "unknown" ?

[birkett]

I like the idea of having the board name visible, it is possible someone has two similar machines using different boards. The way I originally handled the #ifdef mess was a bit of a hack - your suggestion of using pins_*.h has cleaned it up significantly.

@lintz originally mentioned temperature sensors and power supply in #4152
I can't see any clean way of implementing thermistor names. Any suggestions, or skip entirely?

The print job info is on my list, but will need a getter method adding to the PrintCounter class. Any objections?

[thinkyhead]

You can just use #undef BOARD_NAME and remove the #ifdef block.

[thinkyhead]

It looks like you need to do a git rebase upstream/RCBugFix to bring your branch up to date.

git fetch upsteam
git checkout info-menu
git rebase upstream/RCBugFix
git push -f

[thinkyhead]

I can't see any clean way of implementing thermistor names. Any suggestions, or skip entirely?

Actually, it's not pretty, but there is a trick you can do by using #include inline…

#define THERMISTOR_ID TEMP_SENSOR_0
#include "get_thermistor_name.h"
STATIC_ITEM(MSG_THERMISTOR " 0: " THERMISTOR_NAME);

#if TEMP_SENSOR_1 != 0
  #undef THERMISTOR_ID
  #define THERMISTOR_ID TEMP_SENSOR_1
  #include "get_thermistor_name.h"
  STATIC_ITEM(MSG_THERMISTOR " 1: " THERMISTOR_NAME);
#endif

#if TEMP_SENSOR_2 != 0
  #undef THERMISTOR_ID
  #define THERMISTOR_ID TEMP_SENSOR_2
  #include "get_thermistor_name.h"
  STATIC_ITEM(MSG_THERMISTOR " 2: " THERMISTOR_NAME);
#endif

#if TEMP_SENSOR_3 != 0
  #undef THERMISTOR_ID
  #define THERMISTOR_ID TEMP_SENSOR_3
  #include "get_thermistor_name.h"
  STATIC_ITEM(MSG_THERMISTOR " 3: " THERMISTOR_NAME);
#endif

Then your get_thermistor_name.h include file simply does:

#undef THERMISTOR_NAME
#if THERMISTOR_ID ==       -3
  #define THERMISTOR_NAME  "MAX31855"
#elif THERMISTOR_ID ==     -2
  #define THERMISTOR_NAME  "MAX6675"
#elif THERMISTOR_ID ==     -1
  #define THERMISTOR_NAME  "AD595"
#elif THERMISTOR_ID ==      1
  #define THERMISTOR_NAME  "100k"
. . .
#endif

[lintz]

@birkett
For me it would be enough to see the defines such as

Board type: BOARD_RAMPS_14_EFB
Thermistor : 1
Extruders : 1
Min temp extruder: 5
Max temp extruder: 285 

Just as examples I took these. Of course printing the names rather then de defines would make the menu look nicer but not needed for me. O and thanks for taking up the task this fast :)

[jbrazio]

You don't have to use inline here, as you're defining the body of the method inside the header the compiler with automatically inline this for you.

[birkett]

Changed on next push.

[Blue-Marlin]

2 times static void lcd_info_menu(); ???

[birkett]

I cocked up the merge, fixed on next push.

[birkett]

@thinkyhead I figured that would be the way around it, but was unsure if you had any plans for the future.

[thinkyhead]

#if ENABLED(PRINTCOUNTER)

[thinkyhead]

Neat, but no. Don't add extra spaces within the function call.

[jbrazio]

Just the () thing, you can leave the comments aligned.

[thinkyhead]

@birkett This is getting pretty ugly, and active PRs really need to be kept up to date, otherwise they are difficult to work on, we have to make our own copies of your branch, and then we might have to throw away your PR and make our own. It ends up being a lot of extra work for everyone. Unfortunately, we can only add PRs to your branch, we cannot rebase it without making our own copies.

Do you know how to use git to rebase and squash commits?
I can suggest some resources to help explain the process.

[birkett]

I'm familiar with rebase / squash. I planned on squashing down to one or two commits once it is "complete".

[thinkyhead]

You can do whatever you want with your branch and commits, then use git push -f to publish the alterations. So, please, do frequently use…

git fetch upstream ; git rebase upstream/RCBugFix ; git push -f

…and we can adapt to your branch as it changes.

[thinkyhead]

Your branch is looking a lot cleaner, thanks! Meanwhile, your concept of STATIC_ITEM_VAR won't work as it is. What we should do instead is to make STATIC_ITEM and lcd_implementation_drawmenu_static each take an additional argument — an optional string pointer. If the pointer is NULL, print normally. If it points to a string (such as the result of ftostr52sp(my_val) then append that to the current line. I will code that and post a PR for you shortly.

[birkett]

Thanks @thinkyhead - are there any other comments you have, or changes you would like made?
Is there any additional info that should be listed?

[thinkyhead]

We can always extend it later. It's great to just have the basics ready to go.

[thinkyhead]

As this is disabled by default, it's no problem to merge this shortly. It needs a tweak to scroll properly, but I will work on that and patch STATIC_ITEM later, as it is also used by the new M600 feature.