Skip to content

Patch for STATIC_ITEM_VAR ability#4

Merged
birkett merged 5 commits intobirkett:info-menufrom
thinkyhead:rc_birkett_info_menu_jul2
Jul 2, 2016
Merged

Patch for STATIC_ITEM_VAR ability#4
birkett merged 5 commits intobirkett:info-menufrom
thinkyhead:rc_birkett_info_menu_jul2

Conversation

@thinkyhead
Copy link

@thinkyhead thinkyhead commented Jul 2, 2016

  • Add an extra (optional) string argument to lcd_implementation_drawmenu_static.
  • lcd_implementation_drawmenu_static prints left-justified by default.
  • Make lcd_implementation_drawmenu_static contingent on LCD_INFO_MENU.
  • Pass an extra value in STATIC_ITEM to display values.
  • Can't mix STATIC_ITEM and MENU_ITEM, so make Printer Info a submenu of About Printer.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be MSG_INFO_PRINTER_MENU

@thinkyhead thinkyhead force-pushed the rc_birkett_info_menu_jul2 branch 2 times, most recently from 9e0ea3d to 9890ea7 Compare July 2, 2016 21:16
@birkett
Copy link
Owner

birkett commented Jul 2, 2016

Much better, thanks. I'll give it a few hours, then merge.

@thinkyhead
Copy link
Author

I think I'm done patching it up, so go for it anytime. Cheers!

@birkett birkett merged commit af7b40c into birkett:info-menu Jul 2, 2016
@thinkyhead thinkyhead deleted the rc_birkett_info_menu_jul2 branch July 2, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants