Skip to content

Fix broken build on LPC1768#17961

Closed
Desuuuu wants to merge 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Desuuuu:host-actions-fix2
Closed

Fix broken build on LPC1768#17961
Desuuuu wants to merge 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Desuuuu:host-actions-fix2

Conversation

@Desuuuu
Copy link
Copy Markdown
Contributor

@Desuuuu Desuuuu commented May 11, 2020

PR #17953 caused build issues on HALs which include host_actions.h indirectly through their serial emergency parser.

This reverts all PGM_P references to const char * as they were before as well as the MarlinConfig.h include that was causing the issue.

Fixes issue #17955.

@thinkyhead
Copy link
Copy Markdown
Member

Just needed to add an include of Marduino.h to get PGM_P defined.

@thinkyhead thinkyhead closed this May 12, 2020
@Desuuuu Desuuuu deleted the host-actions-fix2 branch May 12, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants