Fix host_action_notify calls passing SRAM pointers #17953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
host_action_notifyfunction expects a PROGMEM pointer but it is passed an SRAM one in some cases (byMarlinUI::set_statusfor example), resulting in garbled data being printed on the serial interface. This behaviour can be observed by simply calling M117 with any string.This PR adds a new
host_action_notify_Pfunction specifically taking a PROGMEM pointers and changeshost_action_notifyto take an SRAM pointer.Calls to
host_action_notifywere updated to use the correct function.Some variable types were also changed to use the
PGM_Pdefine.