Fix warning regarding possible buffer overrun

[sjasonsmith]

Description

Fix a warning indicating the sprintf command could overrun the destination buffer.

'%i' directive writing between 1 and 6 bytes into a region of size between 5 and 10 [-Wformat-overflow=]

The solution was two-fold:

• Make temp an int16_t to reduce the maximum printed length (this matches the source data size)
• Use C99-style format specifier to ensure the format specifier matches the argument length on all platforms.

Related Issues

#17506

[tpruvot]

Good on the F1, removes the warning, was introduced by #17459
Another solution was to extend the 24 bytes buffer to 28 bytes

[thinkyhead]

I wonder if it would be beneficial to apply the same format specifier elsewhere…

[sjasonsmith]

I wonder if it would be beneficial to apply the same format specifier elsewhere…

Fortunately newer versions of gcc are a lot better about warning you when they will cause issues. At least on intel architectures you could have bad behaviors if the format specifier and argument mismatched, because if arguments had to be passed on the stack it would pop the wrong number of bytes from the stack at the end of the call.