Add SRAM command injection#17459
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Apr 10, 2020
Merged
Conversation
thinkyhead
force-pushed
the
bf2_fix_queue_injection_PR
branch
from
a7a7f6b to
4c0bfe6
Compare
Member
thinkyhead
force-pushed
the
bf2_fix_queue_injection_PR
branch
from
4c0bfe6 to
2a2a875
Compare
thinkyhead
force-pushed
the
bf2_fix_queue_injection_PR
branch
from
2a2a875 to
833125e
Compare
ghost
pushed a commit
to bfhobbes/Marlin
that referenced
this pull request
Apr 15, 2020
mathom
pushed a commit
to mathom/Marlin
that referenced
this pull request
Apr 17, 2020
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #17393, #17442, and others…
The main command queue can get filled up regardless of how many extra spaces are left for internal use. This issue was fixed by having an immediate command buffer that bypasses the queue completely while still invoking commands from the correct place in the Marlin main loop. The original solution is light and robust without using a bug SRAM buffer, but since commands must be static strings this limits its use for more complex cases.
This PR adds an SRAM-based immediate command buffer as a compliment to the PROGMEM-based version. Any commands in the SRAM buffer will be executed following commands in the PROGMEM-based buffer, so keep the order in mind if these are used in combination.