Skip to content

Conversation

@guruathwal
Copy link
Contributor

Description

Report machine/bed size and x,y & z axis position limits to the host. The host program/controller can auto-configure settings based on the received details.

Benefits

This is helpful for users who do not know much about compiling firmware for serial host controller like Bigtreetech touch screen controllers where bed dimensions and axis movement limits are needed to configure setting like leveling points or checking if the g-code is within machine limits before sending to the machine to avoid accidents and failures.

@thinkyhead
Copy link
Member

We would have to pick another command for this. M116 is the Wait command.

"Wait for all temperatures and other slowly-changing variables to arrive at their set values if no parameters are specified. See also M109."

But I think what you really want to implement is either an extension to M115 or (for best compatibility with Repetier Firmware) the M360 command.

@guruathwal guruathwal changed the title M116: Report machine/bed size and x,y & z axis movement limits to the host add reporting of machine/bed size and x,y & z axis movement limits to the host in M115 command Feb 1, 2020
@guruathwal guruathwal changed the title add reporting of machine/bed size and x,y & z axis movement limits to the host in M115 command Add reporting of machine/bed size and x,y & z axis movement limits to the host in M115 command Feb 1, 2020
@thinkyhead
Copy link
Member

We prefer not to add features that require a pile of strings for all configurations because Melzi boards have a limited amount of space.

@guruathwal
Copy link
Contributor Author

guruathwal commented Feb 5, 2020

We prefer not to add features that require a pile of strings for all configurations because Melzi boards have a limited amount of space.

The strings can be shorten if they look a lot, like those on Repetier Firmware M360 or even shorter than those or even report as CSV values like:
AREA: 0,200,0,350
XPOS: -10,200
YPOS: 0,200
ZPOS: 0,170
or (CSV)
AREA: 0,200,0,350
XYZPOS: -10,200,0,200,0,170

. Also these will be reported only when EXTENDED_CAPABILITIES_REPORT is enabled. This way it does not look like it can be a problem, or does it?

@thinkyhead
Copy link
Member

thinkyhead commented Feb 9, 2020

If hosts are doing an M360 command as standard practice at this time then I guess 🙄 we may as well adopt it, but it should be disabled by default, and I suppose the feature which enables it can be called REPETIER_GCODE_DIALECT.

I'm not very fond of having these as part of M115 mainly because they can change as different tools are selected and as the workspace changes with M53 - M59.

As an alternative, these parameters could (also) be added to the M408 command which is being added as part of PANELDUE support #10610, but which is also going to be enable-able under an option called RRF_GCODE_DIALECT.

@guruathwal
Copy link
Contributor Author

I think putting the bed/build area reporting under REPETIER_GCODE_DIALECT is not a good idea as the bed/build area are the most common and basic settings in every 3d printer regardless of the Firmware flavor.
Reporting the X carriage Min and Max for both carriages X1 and X2 to the host seems good for the workspace changes.

@thinkyhead thinkyhead changed the title Add reporting of machine/bed size and x,y & z axis movement limits to the host in M115 command Extended reporting WIP Apr 27, 2020
@thinkyhead
Copy link
Member

Rebased and squashed. To update your working copy use the Git Console and the following commands:

git fetch origin
git checkout bugfix-2.0.x
git reset --hard origin/bugfix-2.0.x

@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 3 times, most recently from 711a818 to 7c79515 Compare May 5, 2020 20:53
@thinkyhead thinkyhead merged commit a4c9814 into MarlinFirmware:bugfix-2.0.x May 6, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants