Skip to content

Add zonestar/anet LCD for SKR mini E3#15931

Merged
thinkyhead merged 7 commits intoMarlinFirmware:bugfix-2.0.xfrom
danandrei96:Marlin---SKR-mini-E3-V1.0
Nov 20, 2019
Merged

Add zonestar/anet LCD for SKR mini E3#15931
thinkyhead merged 7 commits intoMarlinFirmware:bugfix-2.0.xfrom
danandrei96:Marlin---SKR-mini-E3-V1.0

Conversation

@danandrei96
Copy link
Contributor

Description

Add option for the Zonestar/Anet LCD controller on the SKR mini E3 board by adding the required pins to the pins file and initialising the ADC for the ADC_KEYPAD_PIN in HAL.cpp

Benefits

Allows using the default Zonestar/Anet A8 LCD with the BTT SKR mini E3 with minimal changes to the LCD (Must convert to 3.3V)

Add option for the Zonestar/Anet LCD controller on the SKR mini E3 board by altering the pins and HAL.cpp files
@thisiskeithb
Copy link
Contributor

Can you add a warning about damaging your LCD if connected to 5V?

@danandrei96
Copy link
Contributor Author

danandrei96 commented Nov 18, 2019

Can you add a warning about damaging your LCD if connected to 5V?

Hi! Added warning about damaging the board if connecting to 5V from the LCD.
Also fixed a small mistake from earlier

Should be good to go now

@thisiskeithb
Copy link
Contributor

I mean something a little more in the user's face in the pins file since this can lead to hardware damage by saying the LCD is supported:

#if ENABLED(ZONESTAR_LCD)
 #error "CONNECTING 5V WILL DAMAGE YOUR LCD. Comment out this line to continue."
#endif

Is there a link to the full mod? That might be useful to include as well. We can't stop people from plugging in the LCD ahead of time, but at least it'll stop the compiling process to make sure the user knows the potential issue.

@danandrei96
Copy link
Contributor Author

I mean something a little more in the user's face in the pins file since this can lead to hardware damage by saying the LCD is supported:

#if ENABLED(ZONESTAR_LCD)
 #error "CONNECTING 5V WILL DAMAGE YOUR LCD. Comment out this line to continue."
#endif

Is there a link to the full mod? That might be useful to include as well. We can't stop people from plugging in the LCD ahead of time, but at least it'll stop the compiling process to make sure the user knows the potential issue.

That's a very good idea. Sorry, it's the first time I contribute so wasn't sure what the best way to add the warning is.
I actually made a youtube video documenting using the SKR board on the Anet A8 a while ago, which includes an explanation of the mod. I also added some instructions to my thingiverse page for the SKR mini E3 mouting also, so could maybe include the url https://www.thingiverse.com/thing:3784828

@thinkyhead thinkyhead merged commit a3229b3 into MarlinFirmware:bugfix-2.0.x Nov 20, 2019
@danandrei96 danandrei96 deleted the Marlin---SKR-mini-E3-V1.0 branch December 7, 2019 14:16
philippniethammer pushed a commit to philippniethammer/Marlin that referenced this pull request Dec 21, 2019
christran206 pushed a commit to christran206/Marlin2.0-SKR-Mini-E3-1.2 that referenced this pull request Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments