Fix Ender-2 display on SKR mini E3 boards#15997
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Nov 26, 2019
Merged
Fix Ender-2 display on SKR mini E3 boards#15997thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
LinoBarreca
pushed a commit
to LinoBarreca/Marlin
that referenced
this pull request
Dec 18, 2019
philippniethammer
pushed a commit
to philippniethammer/Marlin
that referenced
this pull request
Dec 21, 2019
christran206
pushed a commit
to christran206/Marlin2.0-SKR-Mini-E3-1.2
that referenced
this pull request
Dec 30, 2019
thinkyhead
pushed a commit
to greppp/Marlin
that referenced
this pull request
Jan 4, 2020
Resolving MarlinFirmware#15624 Fixing Ender 2 stock LCD pinout for use with SKR V1.3 Boards. Board pinout : https://github.com/bigtreetech/BIGTREETECH-SKR-V1.3/blob/master/BTT%20SKR%20V1.3/hardware/SKR-V1.3-PIN.pdf Used tested pinout from MarlinFirmware#15624 (comment), and used tip from MarlinFirmware#15997 to add the missing pin BTN_ENC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#15924 added support on the
SKR mini E3boards for theEnder 2display. This PR corrects a minor bug in the pin configuration (using PB5 as theCR10display pinout specifies) that caused the screen to remain blank.This PR also corrects another minor bug introduced by #15931, where the definition of
BTN_ENCwas moved into theCR10display's#if(was before underHAS_SPI_LCD, thus applying to all displays), which we need for the button presses to work properly. I added that pin definition to theMKS_MINI_12864, and the button works as expected.Benefits
This PR fixes two minor issues with the
Ender 2screen when hooked up to anSKR mini E3.Related Issues
#15624