Update G34 for non-BLTouch probes#14380
Merged
thinkyhead merged 1 commit intobugfix-2.0.xfrom Jun 24, 2019
unknown repository
Merged
Update G34 for non-BLTouch probes#14380thinkyhead merged 1 commit intobugfix-2.0.xfrom unknown repository
thinkyhead merged 1 commit intobugfix-2.0.xfrom
unknown repository
Conversation
ghost
mentioned this pull request
thinkyhead
changed the title
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESTED, can be merged
Part of the BLTOUCH cleanup. In preparation for later changes in motion.cpp.
Instead of a conditional bltouch.stow() in certain cases, use the STOW_PROBE macro.
The probe (whatever kind) is left deployed after the last call of many calls to probe_pt(...) in the iterations of the G34 process.
It is a good idea to STOW_PROBE unconditionally, because the probe might not be a BLTOUCH at all.
Now that BLTOUCH is included well in the STOW_PROBE macro, it is sensible to handle it via that route in those places where any kind of special BLTOUCH handling is not necessary.
Travel to the homing point will occur in STOWED configuration. Then Z homing will occur.
If the while loop is terminated due to probe failure, the probe_pt(...) function will have STOWed the probe itself.
Planned changes in motion.cpp would break the current version, and I don't want to create a huge PR, so this one should come first in a step by step process.