[2.0.x] Anycubic Trigorilla 14 pins tweak

[Palatis]

follow up #11730

1. add missing pin definisions like FAN2_PIN and HEATER_1_PIN
2. warn the user about the conflict between E1_CS_PIN and FAN2_PIN, instead of directly #undef them altogether.

[Palatis]

I confirmed that E1 EN/DIR/STEP are correct on my board.

I connected a stepper on that and it turns (in both direction.)
However I have only one extruder so no further test is done.

[thinkyhead]

Pins files define the pins that should be used, and don't specify that a pin actually is used. So this warning will be unnecessary for the case where (1) no second fan is being used, (2) the second E plug is unused, etc. If this warning is needed, it would be best to have it in SanityCheck.h at a point where more conditions can be checked. But I'm not sure at the moment how we can determine that the CS_PIN and FAN2_PIN are definitely being used even there. We have to further check whether SPI is applicable to the selected stepper drivers.

[Palatis]

what do you suggest on this one, then? strip the check altogether and rely on the "carefulness" of the user?

[thinkyhead]

what do you suggest on this one, then?
strip the check altogether and rely on the "carefulness" of the user?

No. I suggested improving the sanity check.

[Palatis]

what do you suggest on this one, then?
strip the check altogether and rely on the "carefulness" of the user?

No. I suggested improving the sanity check.

thanks for the explaination, English is not my native.

[Palatis]

ouch... accidently pushed the wrong branch...

[thinkyhead]

Rebased and resolved conflicts. Will merge soon. To get the latest:

git checkout bugfix-2.0.x-anycubic_trigorilla_14
git fetch origin
git reset --hard origin/bugfix-2.0.x-anycubic_trigorilla_14

The added commit should produce the same results for the IS_RAMPS_EFB case, while also giving appropriate (and also matching) results for other possible configurations, such as EXTRUDERS > 1 (EEF, EEB) and TEMP_SENSOR_BED != 0 (EFB, EEB).

[thinkyhead]

@Palatis — You completely reverted my changes to the pins file, which were intended to provide compatibility with a wider variety of setups. Did you not follow my instructions above?

[thinkyhead]

Rebased and resolved conflicts. Will merge soon. To get the latest:

git checkout bugfix-2.0.x-anycubic_trigorilla_14
git fetch origin
git reset --hard origin/bugfix-2.0.x-anycubic_trigorilla_14

The added commit should produce the same results for the IS_RAMPS_EFB case, while also giving appropriate (and also matching) results for other possible configurations, such as EXTRUDERS > 1 (EEF, EEB) and TEMP_SENSOR_BED != 0 (EFB, EEB).

[Palatis]

I'm very sorry about this.

I used my old "auto-rebase-everything-to-upstream" script which switch between several branches and trying to rebase them alone the upstream (in this case, the official Marlin 2.0.x branch), and then force-push to my own repo.
When the script is been written I didn't realize that others can push to the same PR branch on my own repo...

I'm really really sorry about this, please accept my apology.