[2.0.x] Anycubic LinearPlus, Trigorilla 1.4#11730
[2.0.x] Anycubic LinearPlus, Trigorilla 1.4#11730thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
9b6597e to
3963686
Compare
|
Perhaps @ANYCUBIC-3D would like to review this…? |
|
we should check the diffs with my #11725 and check if we can unify them more |
|
Is the AnyCubic LinearPlus the same as the "Kossel"? To compare configs, I usually just drop the ones I want to compare onto the configs open in Github Desktop and then the diffs are all highlighted and ready to cherry-pick line by line. |
|
Yes, the full name should be Anycubic Kossel Linear Plus - it's the bigger brother of the normal Anycubic Kossel. I did some initial comparing of the 2 configs, and it looks like I activated way more features on my version (Autocalibration, other convenience things...) - I'll work on unifying the configs and will provide an updated pull request for Anycubic Kossel and Anycubic Kossel Linear Plus so I vote against merging our 2 pull requests for now |
|
You can just add commits to your PR's branch to update it. I posted instructions there. And, you can submit any changes to this PR by
When I merge your PR to |
9d94fd1 to
cec7c3f
Compare
|
please discard in favour of #11752 |
cec7c3f to
cca9980
Compare
|
I brought your changes into this PR instead. I also combined the V1 / V2 configs to cut the number of configs in half. |
|
Thanks - although I work with git daily, github does some things differently than we do, so I was confused. I'll add another sample config soon (as soon as I've tested it) for the version without heated bed and without autolevel. Who could support me with issue #11337 because it makes this firmware a bit dangerous for the unaware (can break the z-probe)? |
Co-Authored-By: grbd <garlicbready@googlemail.com>
Co-Authored-By: grbd <garlicbready@googlemail.com>
cca9980 to
a2bf6ec
Compare
|
I think the pins are correct for E1 except E1_CS_PIN (which is used for FAN2_PIN) however I prefer something like so it don't |
|
@Palatis can you provide a pull request for this change? |
Changes from #11356 @grbd