[2.0.x] Improved SW micro stepping configuration#11132
Closed
TheLongAndOnly wants to merge 9 commits intoMarlinFirmware:bugfix-2.0.xfrom
Closed
[2.0.x] Improved SW micro stepping configuration#11132TheLongAndOnly wants to merge 9 commits intoMarlinFirmware:bugfix-2.0.xfrom
TheLongAndOnly wants to merge 9 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
added 2 commits
June 27, 2018 21:46
thinkyhead
reviewed
Jun 28, 2018
Marlin/Configuration_adv.h
Outdated
| * are defined. At max, 3 MS PINS are supported, if less are defined, the last settings are ignoreds | ||
| */ | ||
| //#define MICROSTEP_CUSTOM | ||
| #ifdef MICROSTEP_CUSTOM |
Member
There was a problem hiding this comment.
Required for Marlin:
#if ENABLED(MICROSTEP_CUSTOM)
thinkyhead
reviewed
Jun 28, 2018
Marlin/src/inc/Conditionals_post.h
Outdated
| #define MICROSTEP16 LOW,LOW | ||
| #define MICROSTEP32 HIGH,HIGH | ||
| // MS1 MS2 MS3 Stepper Driver Microstepping mode table | ||
| #ifndef MICROSTEP_CUSTOM |
Member
There was a problem hiding this comment.
#if DISABLED(MICROSTEP_CUSTOM)
added 4 commits
June 28, 2018 20:21
Contributor
Author
|
Thanks for the feedback. I changed this and added a few more checks to ensure backwards compatibility in case only 2 micro stepping pins are defined. |
added 2 commits
July 1, 2018 19:16
…cro step selection - Board dependencies removed.
Contributor
Author
|
Same here as other pull requests currently failing: |
This was referenced Jul 4, 2018
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
2 times, most recently
from
f454bf2 to
63f4c9b
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
4 times, most recently
from
0226dcc to
834ea7f
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
4 times, most recently
from
9fb4e95 to
ad12b9b
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
5f6db62 to
d0c96ee
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
2 times, most recently
from
9d867f9 to
849dea9
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
2 times, most recently
from
579c7f3 to
d52deeb
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
8a7664f to
5d487ef
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
d047d11 to
a163c89
Compare
Contributor
Author
|
Strangly I cannot see this comment in Github. So replying to the Mail.
This is pretty old code and I would need to rebase it as many things have changed, which partially already cover this PR. Give me a moment to check.
… Am 10.11.2018 um 19:03 schrieb Ryan ***@***.***>:
This looks like it could fix the last of the major issues with getting the Archim1 boards ready for Marlin 2.0. Would it help if I updated all the configs or is there a script for that sort of thing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#11132 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYrR9iYRrqpstLUfoSgNecpX4wotmhxFks5utxT2gaJpZM4U6SzK>.
|
Contributor
|
Sorry, I deleted the comment as I realized it already seems to be in the bugfix branch. I guess it got pulled between my updates. I think this can be closed now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current micro stepping configuration is only limited to 2 pins. In addition there is only a fixed definition for the modes in Conditional_posts.h, which is not very flexible.
This pull requests extends implementation to 3 micro stepping pins (which many drivers require) and allows to define custom micro stepping pin settings in Configuration_adv.h.