[1.1.x] Junction Deviation#10650
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom May 8, 2018
Merged
Conversation
thinkyhead
force-pushed
the
bf1_junction_deviation
branch
from
424fe8c to
cc6071b
Compare
Squid116
reviewed
May 8, 2018
Marlin/planner.cpp
Outdated
Contributor
There was a problem hiding this comment.
We have already set vmax_junction to MINIMUM_PLANNER_SPEED above, we could invert the if and skip this block?
if (junction_cos_theta < 0.999999) {
junction_cos_theta = max(junction_cos_theta, -0.999999); // Check for numerical round-off to avoid divide by zero.
etc...
1ef1c52 to
cd944ea
Compare
thinkyhead
force-pushed
the
bf1_junction_deviation
branch
from
cd944ea to
b3af5a1
Compare
Squid116
reviewed
May 8, 2018
Marlin/planner.cpp
Outdated
Contributor
There was a problem hiding this comment.
much neater than my attempt!
Marlin/planner.cpp
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #10341…
Add an alternative method for jerk limiting that takes account of the angle of deviation.
Adapted from Grbl, with finishing touches incorporated from https://github.com/Squid116/Marlin/tree/bugfix-1.1.x
Concise Diff
Counterpart to #10651