[1.1.x] Round floats in string conversion functions#10565
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom Apr 29, 2018
Merged
[1.1.x] Round floats in string conversion functions#10565thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #10420
Because floats are truncated their inherent rounding behavior can cause displayed values to be confusing. This PR applies the
FIXFLOATmacro to all the fast string conversion functions for floats to round them before display.Counterpart to #10566