Galera macos #23
Open
Galera macos #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-ssl-cert-chain-gen
…to phase-out-shared-4.ee-cleanup
…' into 4.ee-asio-server-handshake-failure
…o 4.ee-fix-wsrep-api-submodule
added pipeline logic for 4.ee
pipeline concept to replace multijob logic
Conflicts: gcs/src/gcs_defrag.cpp
1) Hide system error numbers and messages from thrown exceptions System error numbers and messages cause confusion when used in contexts where system calls are not involved. Hide the system error number and message from exception messages and create separate ThrowSystemError class and gu_throw_system_error() macro for contexts where the system error number is relevant. 2) Fix error and warning messages not to use strerror Using `strerror()` with error code in contexts where the error code does not come from a system call may cause very misleading error messages. Replace `strerror()` use around GCS code with two functions gcs_error_str() and gcs_state_transfer_error_str() in contexts where printing system error might be misleading. 4) Fix gcomm error logging Change several warning level messages into info level messages for cases which may happen during normal operation because of network partitionings or cluster configuration changes. Remove redundant warning messages in cases where the error handling is handled by caller. 5) Convert gcs warning messages to info Convert GCS messages which don't indicate any required action from admin (e.g. error conditions will be dealt with retrying or are result of expected conditions like network partitioning) into info or debug messages. 6) Propagate IST error to IST event handler The IST error is logged when the IST event queue becomes empty and one of the appliers read the error status. This is to avoid duplicate error logging from several contexts.
Conflicts: debian/changelog
…ructs gcs, gcs_core, gcs_group instead of using calloc() - make gcs_register_params() take gu::Coonfig& and return void in line with other such methods
|
tested 78f68e9 on MBP M3Max ( works well! I have managed to execute Galera node and join another node. |
|
@janlindstrom as tested, can the this be deconflicted and merged? |
|
Actually looking the the commit messages it looks like its all been merged in #32. Can you confirm? |
|
seems to be true - https://github.com/MariaDB/galera/blob/mariadb-4.x/gcs/src/gcs_core.cpp#L128 - gcs_core::gcs_core() now has constructor in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.