-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManimCE violates the GNU GPL license #2418
Comments
I think this is a valid concern. @naveen521kk @PhilippImhof what do you think? |
It would not be hard to change ManimPango, as it only has like 6 contributors, and if any don't respond you can always overwrite their small changes. I would suggest converting it to MIT |
Removing ManimPango does not seem to be very straightforward for me, because we would lose all non-LaTeX text functionality. However, I am absolutely fine with changing the license. @naveen521kk has contributed much more than I, but I think he would not mind either. For me, any license is fine. |
By straightforward I've only meant the restoring of compliance with GPL. The first two proposed resolutions have far reaching consequences for users of ManimCE. Thus in that regard the third one is actually the most straightforward. |
Yeah, I am fine with that. I have written most of the code there and it's fine for me to relicense to something like LGPL. I faintly remember making a private conversation with @PhilippImhof about this a long time ago.
If I understand the licenses correctly I think ManimPango can't be licensed under something which isn't GPL or LGPL based because Pango has been licensed under LGPL, right? I would be happy to release under BSD or MIT licenses if I'm allowed to, but I'm not sure. |
I have had a look at the commits. As I can see, we have @jsonvillanueva who contributed one commit related to the code of conduct. As we are mainly talking about the code's license, this is not important. I still tagged them, so we can get their stance on the issue. We also have @leotrs who did some (very minor) change to the docstrings in ManimCommunity/ManimPango#10. I tagged him anyhow, because it is a good opportunity to greet him :) Next is @RickyC0626 with three commits. Could they please tell whether they agree with a change of license with or without reservation? And finally, we have @marcin-serwin. As they raised the issue and suggested a change of license, I believe they have nothing against it? I think it is best to ask the folks over at Pango whether ManimPango can be licensed as MIT or BSD, but as @naveen521kk says, I also think LGPL will be the way to go. However, I am by no means an expert for licensing questions. |
Is it just bindings or does it contain any Pango code. If the former it can be MIT if the latter then it has to be GPL. |
IIRC it's only bindings, but I'd rather wait for @naveen521kk to confirm... |
It's just the bindings. Can you show an example where the binding is licensed under MIT while the main library is LGPL? I am asking this so that I will not be bothered to change the license of that code again. |
BTW LGPL is not compatible with GPL2, nor is GPL3. The search terms copyright and binding give too much noise so I don't know. |
Uggggg
|
Honestly, we are getting rid of cario, we should probably get a new text renderer too. |
I'm fine with a license change, whichever decision best benefits the community. Since Pango is using the old LGPLv2 license, and not LGPLv2.1, it would not be compatible with GPL, but it would offer more freedom of use. |
@GameDungeon The cited passages refer to GPL, but Pango (and Cairo) are released under LGPL. To be more precise Pango is under LGPL 2.0, section 6 of this license states (emphasis mine):
There are other requirements for use, but my basic understanding is that ManimPango and Manim can be released as MIT provided that they contain license text and mention the usage of LGPL content somewhere. On a related note it may be a good idea to create some main document (e.g. |
Ah I though Pango was GPLv2 my bad. |
So changing the license of ManimPango to MIT, should work right? And mention somewhere (in the README and wheels) probably that it contains LGPL code from Pango, should work right? |
All the authors and contributors have agreed to this change. Fixes ManimCommunity/manim#2418
I have made ManimCommunity/ManimPango#72 |
Again, I am not a lawyer, but my understanding is that we need to mention that LGPL code is used and attach full license text. EDIT: The same applies to Manim. |
I have already attached the full license text in the wheels for a long time now: see https://github.com/ManimCommunity/ManimPango/blob/main/packing/LICENSE.bin and I think that should be fine on ManimPango's part I guess, right? I am wondering where it should be mentioned in manim though. Even pycairo/cairo is LGPL and we haven't mentioned it anywhere. Should we email FSF for clarification (I think they should help out right?)? |
I suggest we'd rather ask the people over at Pango (and maybe Cairo). It's their software, so they could also just grant an exception if it is not 100% correct but does not bother them. |
* Change to MIT license All the authors and contributors have agreed to this change. Fixes ManimCommunity/manim#2418 Also, * Add note about license in README * Update setup.py to reflect license change
Firstly, I am not a lawyer and this is only my understanding.
ManimPango is licensed under the GPLv3. As per the license terms this means that the program linking to it must be released under the GPL license (see FAQ). Manim uses ManimPango, thus it should be licensed under the GPLv3, but it isn't.
As I see it (again, I am not a lawyer), there are three ways to resolve it:
The text was updated successfully, but these errors were encountered: