Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs #10

Merged
merged 13 commits into from
Jan 13, 2021
Merged

Add Docs #10

merged 13 commits into from
Jan 13, 2021

Conversation

naveen521kk
Copy link
Member

A sphinx based docs setup. Should be useful in future, but let it be for now.

@naveen521kk
Copy link
Member Author

@naveen521kk naveen521kk enabled auto-merge (squash) January 10, 2021 13:29
@naveen521kk naveen521kk requested a review from behackl January 10, 2021 13:30
Copy link
Member

@PhilippImhof PhilippImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@naveen521kk
Copy link
Member Author

If it's ok @PhilippImhof can you give an approve?

Co-authored-by: Leo Torres <[email protected]>
@naveen521kk
Copy link
Member Author

naveen521kk commented Jan 13, 2021

I think @leotrs you don't have write access to this repo. or else it should have been merged by now. anyway, I will merge it.

@naveen521kk naveen521kk disabled auto-merge January 13, 2021 15:47
@naveen521kk naveen521kk merged commit 256c6fc into main Jan 13, 2021
@naveen521kk naveen521kk deleted the docs branch January 13, 2021 15:47
@leotrs
Copy link
Contributor

leotrs commented Jan 13, 2021

I believe I do have access, I think I just forgot to merge after accepting 😅

@naveen521kk
Copy link
Member Author

naveen521kk commented Jan 13, 2021

I had enabled auto-merge which means, it should have merged automatically if you had write access.

@leotrs
Copy link
Contributor

leotrs commented Jan 13, 2021

Oh snap, then I don't 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants