Fix bug where a GET triggered by a test, is processed after the test #9733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sporadically, I was noticing the GET below happening during the teardown
of the test:
"/api/tenants?filter[]=name=&expand=resources"
It turns out we have a form validation for the name field that gets a list of
tenant names on form load to prevent the user from providing a duplicate name.
For the edit tenant form, we ALSO have an API tenant data request that occurs BEFORE
the tenant form loads. Because of this, we need to wait on the single form
validation API request for the add form and for the edit form, we need to wait
for the load API request first, then, the same validation API request.
This should fix the following issue that was happening sporadically locally and
in CI:
```
Validate Child Tenant operations: Add, Edit, Add Project, Manage Quotas
Validate Add child tenant function
✖(Attempt 1 of 10) Validate Add child tenant form elements
✖(Attempt 2 of 10) Validate Add child tenant form elements
✖(Attempt 3 of 10) Validate Add child tenant form elements
✖(Attempt 4 of 10) Validate Add child tenant form elements
✖(Attempt 5 of 10) Validate Add child tenant form elements
✖(Attempt 6 of 10) Validate Add child tenant form elements
✖(Attempt 7 of 10) Validate Add child tenant form elements
✖(Attempt 8 of 10) Validate Add child tenant form elements
✖(Attempt 9 of 10) Validate Add child tenant form elements
✖(Attempt 10 of 10) "before each" hook for "Validate Add child tenant form elements"
✖ "before each" hook for "Validate Add child tenant form elements" (30358ms)
6 passing (4m)
1 failing
1) Automate Tenant form operations: Settings > Application Settings > Access Control > Tenants
Validate Child Tenant operations: Add, Edit, Add Project, Manage Quotas
Validate Add child tenant function
"before each" hook for "Validate Add child tenant form elements":
CypressError: `cy.visit()` failed trying to load:
http://localhost:3000/
We attempted to make an http request to this URL but the request failed without a response.
We received this error at the network level:
> Error: ESOCKETTIMEDOUT
```
Fryguy
approved these changes
Nov 19, 2025
Member
Member
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Nov 20, 2025
…ercept-waits Fix bug where a GET triggered by a test, is processed after the test (cherry picked from commit 22ded37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sporadically, I was noticing the GET below happening during the teardown of the test:
"/api/tenants?filter[]=name=&expand=resources"
It turns out we have a form validation for the name field that gets a list of tenant names on form load to prevent the user from providing a duplicate name. For the edit tenant form, we ALSO have an API tenant data request that occurs BEFORE the tenant form loads. Because of this, we need to wait on the single form validation API request for the add form and for the edit form, we need to wait for the load API request first, then, the same validation API request.
This should fix the following issue that was happening sporadically locally and in CI:
Seen in https://github.com/ManageIQ/manageiq-ui-classic/actions/runs/19341780911/job/55331768728