Fix prov_get_form_vars for ConfigurationScriptBase #9728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Going to see about adding spec coverage to this clearly it is lacking |
agrare
force-pushed
the
fix_configuration_script_base_prov_get_form_vars
branch
from
9cb5743 to
fe977de
Compare
Member
Author
|
Okay spec test added which would have caught the original error |
Member
Author
|
@miq-bot cross-repo-test ManageIQ/manageiq#23657 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Nov 19, 2025
From Pull Request: ManageIQ/manageiq-ui-classic#9728
Fryguy
approved these changes
Nov 19, 2025
agrare
force-pushed
the
fix_configuration_script_base_prov_get_form_vars
branch
from
f9b6450 to
b789fc5
Compare
Member
Author
|
Hmm I think cypress is failing sporadically, two different tests have failed in the last two runs |
agrare
force-pushed
the
fix_configuration_script_base_prov_get_form_vars
branch
from
b789fc5 to
3c1f396
Compare
Member
|
Might be fixed by #9733 |
`v` in this case is the result of `allowed_configuration_scripts` and so is an `OpenStruct` but `val` is the selected integer value so calling `.id` fails with: ``` FATAL -- : Error caught: [NoMethodError] undefined method `id' for an instance of Integer app/controllers/application_controller/miq_request_methods.rb:836:in `block (2 levels) in prov_get_form_vars' app/controllers/application_controller/miq_request_methods.rb:781:in `each' app/controllers/application_controller/miq_request_methods.rb:781:in `block in prov_get_form_vars' ```
agrare
force-pushed
the
fix_configuration_script_base_prov_get_form_vars
branch
from
3c1f396 to
c1d6ea8
Compare
Member
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Nov 20, 2025
…ov_get_form_vars Fix prov_get_form_vars for ConfigurationScriptBase (cherry picked from commit 241cefb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vin this case is the result ofallowed_configuration_scriptsand so is anOpenStructbutvalis the selected integer value so calling.idfails with:Depends on: