Split ibm cloud credentials from ibm classic infra credentials #23
Conversation
| if %i[classic_user classic_key].any? { |opt| attrs.key?(opt) } | ||
| attrs[:userid] = attrs.delete(:classic_user) if attrs.key?(:classic_user) | ||
| attrs[:password] = attrs.delete(:classic_key) if attrs.key?(:classic_key) | ||
| end |
There was a problem hiding this comment.
I think this just goes away if classic user/key are moved to the other class as auth_key is required, right?
| :isRequired => true, | ||
| :validate => [{:type => 'required'}], | ||
| }, | ||
| ].freeze |
There was a problem hiding this comment.
I renamed these to userid and password so we don't need to define params_to_attributes here.
jrafanie
force-pushed
the
split_ibm_cloud_into_cloud_and_classic_infra_credentials
branch
2 times, most recently
from
a8fac8d to
6f86e00
Compare
jrafanie
changed the title
jrafanie
force-pushed
the
split_ibm_cloud_into_cloud_and_classic_infra_credentials
branch
from
6f86e00 to
a8356c6
Compare
|
Makes sense to me, @putmanoj can you confirm this will work for opentofu-runner / ibm_cloud provider |
|
Only comment I have here is I think it should it be "IBM Cloud Classic Infrastructure" vs "IBM Classic Infrastructure"? (it's this way in various strings, class names, factory names etc, so I think it would have to change everywhere) |
My goal was to avoid confusing people by having IBM Cloud and IBM Cloud Classic Infrastructure in the select list. I saw Classic Infrastructure all over the place here and figured maybe we could use it: https://cloud.ibm.com/docs/account?topic=account-classic_keys. I'm good with whatever users would know the names to be. |
|
Checked commits jrafanie/manageiq-providers-embedded_terraform@a8356c6~...2827fc2 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Ok, renamed to IBM Cloud Classic Infrastructure. The screenshots are updated. |
|
Ready to go |
jrafanie
deleted the
split_ibm_cloud_into_cloud_and_classic_infra_credentials
branch
5 participants
I think this simplifies the required field logic. We'll need to make sure connecting from within the runner works but this is the start of enabling that work.