Simplify description from credentials PR #16 #21
Conversation
jrafanie
force-pushed
the
simplify_descriptions
branch
from
809be52 to
3562377
Compare
app/models/manageiq/providers/embedded_terraform/automation_manager/ibm_cloud_credential.rb
Outdated
Show resolved
Hide resolved
|
Checked commits jrafanie/manageiq-providers-embedded_terraform@0894742~...3562377 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
| :component => 'password-field', | ||
| :label => N_('IBM Cloud API Key'), | ||
| :helperText => N_('The API key for IBM Cloud. A value for this field is required if classic user name and classic API key are not provided. A valid connection must have value for IBM Cloud API Key or, IBM Cloud Classic Infrastructure User Name and IBM Cloud Classic Infrastructure API Key.'), | ||
| :helperText => N_('The API key for IBM Cloud. This credential requires either an IBM Cloud API Key or both a Classic Infrastructure User Name and Classic Infrastructure API key.'), |
There was a problem hiding this comment.
Does something like this work?
| :helperText => N_('The API key for IBM Cloud. This credential requires either an IBM Cloud API Key or both a Classic Infrastructure User Name and Classic Infrastructure API key.'), | |
| :helperText => N_('The API key for IBM Cloud. This credential requires either an IBM Cloud API Key or a Classic Infrastructure User Name / API key pair.'), |
There was a problem hiding this comment.
Or perhaps
Does something like this work?
| :helperText => N_('The API key for IBM Cloud. This credential requires either an IBM Cloud API Key or both a Classic Infrastructure User Name and Classic Infrastructure API key.'), | |
| :helperText => N_('The API key for IBM Cloud. This credential requires either an IBM Cloud API Key or a Classic Infrastructure User Name and API key.'), |
There was a problem hiding this comment.
yeah, English vs. logical makes that not obvious. I think I like the second one. I'm not a fan of duplicating the same thing 3 times here so do wish we could put this logic into the validation for this form though so we can help the user if they don't provide the right things.
There was a problem hiding this comment.
Agreed - maybe some tabs? like we do for multiple auths?
There was a problem hiding this comment.
actually, separate credential types feels easier
There was a problem hiding this comment.
I agree, let me split off this into a new PR and get the other change in. I'll create a new credential type and play with that.
There was a problem hiding this comment.
Ok, split it off into a separate class. This will allow us to test both IBM Cloud and IBM Classic Infrastructure: #23
jrafanie
force-pushed
the
simplify_descriptions
branch
from
3562377 to
0894742
Compare
jrafanie
changed the title
|
NOTE: I'll split off the IBM Cloud credentials into a followup PR with two types: cloud and classic infrastructure.
|
|
This should be ready to go |
5 participants
This PR simplifies a few descriptions from #16
Updated screens: