Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Android 13 Tiramisu (API 33) #1597

Closed
bartekpacia opened this issue May 16, 2022 · 10 comments · Fixed by #1658
Closed

Support for Android 13 Tiramisu (API 33) #1597

bartekpacia opened this issue May 16, 2022 · 10 comments · Fixed by #1658

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented May 16, 2022

Android 13 introduces new runtime permission for notifications.

I've looked but haven't found any mention about it in the package's README on pub.dev.

So I suggest that AndroidFlutterPluginImplementation should get requestPermissions method, similar to iOSFlutterPluginImplementation

@MaikuB
Copy link
Owner

MaikuB commented May 19, 2022

Thanks for raising this. Do you think could you submit a PR for this? One thing I'm also wondering is given how Android 13 appears to be in beta, I assume that making a stable release of the plugin depend on the Android 13 SDK isn't the way to go as this could cause issues for that don't have the SDK, which in turn requires a preview version of Android Studio. Is this right? If so, I suppose that support for this would require being in a pre-release so it's up to developers to opt-in with using the functionality just as they would do for using an SDK in preview?

@bartekpacia
Copy link
Contributor Author

Hi @MaikuB 👋

Yes, I'd be very happy to submit a PR for this. Unfortunately I've encountered problems at the very beginning. Looks like Flutter (flutter_tools, to be precise) can't build apps that target Tiramisu.

I've submitted an issue about this in flutter/flutter. I think we'll have to wait until it's resolved before we can start working on this (new notification permission) feature.

@MaikuB
Copy link
Owner

MaikuB commented May 19, 2022

Much appreciated. Though the other thing is the SDK itself has various milestones so it may still bit too early to look at. There tends to be a beta where Google states that the APIs are final and and the SDK can be referenced by API level instead of the codename, which in itself is like a breaking change

@bartekpacia
Copy link
Contributor Author

There tends to be a beta where Google states that the APIs are final and and the SDK can be referenced by API level instead of the codename

Yeah, it's called platform stability phase.

Screenshot 2022-05-19 at 1 09 01 PM

Still, I'd like to be able to target Flutter apps on non-stable-yet platforms (i.e referenced by codenames). Let's wait until some Flutter team member answers to that issue and see what they say.

Summing up, I guess that the action item here is to wait until Google declares platform stability :)

@ciriousjoker
Copy link

Any updates? Platform stability has been reached.

@Cubel89
Copy link

Cubel89 commented Jul 28, 2022

I think API 33 is already available

@bartekpacia
Copy link
Contributor Author

Yeah, it is.

@bartekpacia
Copy link
Contributor Author

If no one's interested in doing this, I volunteer. I'd like to get this done over the next few days. Can you assign me @MaikuB?

@mk-dev-1
Copy link

@bartekpacia Much appreciated! Maybe this link will also be helpful here: https://blog.esper.io/android-13-exact-alarm-api-restrictions/

@stephanie-finch
Copy link

@MaikuB Can we prioritize @bartekpacia's pull request?

Android 13 is publicly available out on Pixels now: https://www.theverge.com/2022/8/15/23306058/android-13-release-date-pixel-devices-features

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants