-
Notifications
You must be signed in to change notification settings - Fork 3
More googletest updates #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is necessary on some systems (e.g., RHEL)
|
It does seem like changing this only in memtailor fixes the issue, but technically mathic and mathicgb also have the same issue (if they were to be built independently). This is the error btw: |
|
Yeah -- I was planning on opening similar PR's in mathic/mathicgb once I got the green light from you for memtailor |
Co-authored-by: Mahrud Sayrafi <[email protected]>
|
Oh I see. Sorry I already opened those, but if you have other fixes feel free to open your own version and close mine or just push commits to mine. |
|
I wasn't able to push to your fork so I opened up PR's with the autotools fix: |
|
Do you want to merge those two PR's into yours? Then we can get Mike to merge them all and I'll update the submodules in the release branch |
|
I don't care either way. |
|
Ok -- if you would, go ahead and merge those two. Then your two PR's should get updated automatically |
|
I don't think I have access to merge. |
|
Nevermind, I do there, but oddly not here! |
|
OH LOL the pull requests were onto my forks, sorry I'm not paying attention. |
|
@mikestillman - Would you merge this when you get a chance? |
A couple small googletest updates to squeeze in before the Macaulay2 1.25.05 release:
Cc: @mahrud