Skip to content

Conversation

@d-torrance
Copy link
Member

A couple small googletest updates to squeeze in before the Macaulay2 1.25.05 release:

  • Fetch 1.16 to fix the build with the latest version of cmake
  • Include the pthreads flag for proper detection on some systems (e.g., RHEL) in the autotools build

Cc: @mahrud

@mahrud
Copy link
Member

mahrud commented May 13, 2025

It does seem like changing this only in memtailor fixes the issue, but technically mathic and mathicgb also have the same issue (if they were to be built independently).

This is the error btw:

-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)
CMake Error at BUILD/build/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

@d-torrance
Copy link
Member Author

Yeah -- I was planning on opening similar PR's in mathic/mathicgb once I got the green light from you for memtailor

Co-authored-by: Mahrud Sayrafi <[email protected]>
@mahrud
Copy link
Member

mahrud commented May 13, 2025

Oh I see. Sorry I already opened those, but if you have other fixes feel free to open your own version and close mine or just push commits to mine.

@d-torrance
Copy link
Member Author

I wasn't able to push to your fork so I opened up PR's with the autotools fix:

mahrud/mathic#1
mahrud/mathicgb#1

@d-torrance
Copy link
Member Author

Do you want to merge those two PR's into yours? Then we can get Mike to merge them all and I'll update the submodules in the release branch

@mahrud
Copy link
Member

mahrud commented May 13, 2025

I don't care either way.

@d-torrance
Copy link
Member Author

Ok -- if you would, go ahead and merge those two. Then your two PR's should get updated automatically

@mahrud
Copy link
Member

mahrud commented May 13, 2025

I don't think I have access to merge.

@mahrud
Copy link
Member

mahrud commented May 13, 2025

Nevermind, I do there, but oddly not here!

@mahrud
Copy link
Member

mahrud commented May 13, 2025

OH LOL the pull requests were onto my forks, sorry I'm not paying attention.

@d-torrance
Copy link
Member Author

@mikestillman - Would you merge this when you get a chance?

@mikestillman mikestillman merged commit 07c84a6 into Macaulay2:master May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants