Set googletest to version 1.16.0 #3766
Conversation
We're currently using a commit a little between 1.16 and the just-released 1.17. googletest 1.17 (and the commit we're currently using) requires compiling with C++17 support. This is currently an issue on systems like RHEL where we need to build googletest. Eventually, we should add support for 1.17 by compiling with C++17 support in memtailor/mathic/mathicgb, but it would probably be best to deal with this after the 1.25.05 release. [ci skip]
|
Ah, I think the version of googletest required by mathicgb and friends also needs to be bumped to v1.16.0, otherwise on systems with newer CMake we get an error. Could you update those as well? |
|
Isn't the particular version of googletest that's installed for mathicgb and friends controlled by the M2 repository? |
|
No, their CMake files currently point to v1.11.0. |
|
Oh I see. So that's what it downloads when it can't find googletest? Wouldn't it be okay if 1.16 was already downloaded by the Macaulay2 build? I guess my question is -- should we worry about updating all of those submodules prior to the release? |
|
Yes, I currently can't build with cmake on my system.
…On Tue, May 13, 2025, 7:32 AM Doug Torrance ***@***.***> wrote:
*d-torrance* left a comment (Macaulay2/M2#3766)
<#3766 (comment)>
Oh I see. So that's what it downloads when it can't find googletest?
Wouldn't it be okay if 1.16 was already downloaded by the Macaulay2 build?
I guess my question is -- should we worry about updating all of those
submodules prior to the release?
—
Reply to this email directly, view it on GitHub
<#3766 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYAPRUMXWIAXA23ASOZ76D26HJ23AVCNFSM6AAAAAB4KDF6XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZWGEZTGNZXGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Ok -- I'll open some PR's here in a bit. I have an autotools fix that I'd like to get in too -- right now it's just patches in the release branch, but it would be better to have them in the submodule I think. |
|
I Just opened Macaulay2/memtailor#10 -- does it fix the problem? (I tried testing it but Debian is in freeze right now so the cmake version isn't the latest.) |
2 participants
We're currently using a commit a little between 1.16 and the just-released 1.17. googletest 1.17 (and the commit we're currently using) requires compiling with C++17 support. This is currently an issue on systems like RHEL where we need to build googletest.
Eventually, we should add support for 1.17 by compiling with C++17 support in memtailor/mathic/mathicgb, but it would probably be best to deal with this after the 1.25.05 release.
This commit is cherry-picked from #3683, but I'd like to make sure it gets into the release for the sake of the RHEL builds (see https://github.com/d-torrance/M2-workflows/actions/runs/14789884670).