Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Dec 19, 2017

There is a bug when rerunning analysis in python 3 with time series output. The xtime_startMonthly variable was not being converted correctly to a string. This has been fixed.

@xylar xylar added the bug label Dec 19, 2017
@xylar xylar self-assigned this Dec 19, 2017
@xylar xylar added the priority label Dec 19, 2017
@xylar
Copy link
Collaborator Author

xylar commented Dec 19, 2017

@milenaveneziani, the problem can be reproduced by running a case of your choice on edison using develop with:

export PATH=/global/project/projectdirs/acme/software/anaconda_envs/edison_mpas_analysis_py3/bin:$PATH
./run_mpas_analysis --purge config.<case> --generate=timeSeriesSST
./run_mpas_analysis config.<case> --generate=timeSeriesSST

If you run the same with this branch, you should no longer see the error.

@milenaveneziani milenaveneziani merged commit 402c078 into MPAS-Dev:develop Dec 21, 2017
@milenaveneziani
Copy link
Collaborator

Did the test you mentioned and all worked.

@milenaveneziani
Copy link
Collaborator

milenaveneziani commented Dec 21, 2017

@xylar, leaving a comment here just in case it is not necessary to open an issue: I noticed that, even if I request a time series starting from say year=10, I still get a message on screen that says:

Computing MPAS time series from files:
    mpaso.hist.am.timeSeriesStatsMonthly.0001-01-01.nc through
    mpaso.hist.am.timeSeriesStatsMonthly.0010-12-01.nc

ie, starting from year 1. I assume just the message should be adjusted?

@xylar
Copy link
Collaborator Author

xylar commented Dec 21, 2017

@milenaveneziani, please make an issue for the time series range. I think the issue might be that the first year is included in every time series, regardless of what is requested.

@xylar xylar deleted the fix_time_series_rerun branch December 21, 2017 06:08
@xylar
Copy link
Collaborator Author

xylar commented Dec 21, 2017

Thanks for the quick review!

@milenaveneziani
Copy link
Collaborator

I think the issue might be that the first year is included in every time series, regardless of what is requested.

yes, that is what I think is happening too. I looked into it a bit, and I think it all originates here:

self.inputFiles = self.historyStreams.readpath(
                streamName, startDate=startDate, endDate=endDate,
                calendar=self.calendar)

on line 144 of mpas_time_series_task.py.
So, I think we just have to leave it be.

@xylar xylar mentioned this pull request Jan 26, 2018
xylar added a commit that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants