Skip to content

Conversation

@anku255
Copy link
Member

@anku255 anku255 commented Aug 3, 2020

Summary

Fixes #15

Changelog

  • Added new use case for the Alert API as mentioned in Implement the new Alert Screen #15
  • Wrote each use case in a separate example block to allow searching
  • Wrote Detox tests for the Alert Screen

Test Plan

  • Run the RNTester app locally by following these instructions.
  • Search for Alerts and tap on it

Screenshot 2020-07-07 at 1 21 55 PM

Screenshot 2020-07-07 at 1 29 03 PM

@anku255 anku255 added Final The PR that will be pointed to the facebook repo. Do not delete this branch. RNTester The issues associated with the RNTester project. labels Aug 3, 2020
@chirag-singhal
Copy link

@anku255 these tests most probably will fail with current navigation. Also i tried running some of the tests on migrated RNTester with the new UI, they are acting weird.

@anku255
Copy link
Member Author

anku255 commented Aug 4, 2020

@chirag-singhal yes! you are right. This will fail because of the new navigation. I will update them after the design review.

Also i tried running some of the tests on migrated RNTester with the new UI, they are acting weird.

You mean you ran them on the packages/RNTester? What do you mean by acting weird?

@chirag-singhal
Copy link

@anku255 yes i ran them on packages/RNTester. I guessed atleast component tests should pass, but Modal tests suddenly goes to bookamark screen and then fails. Button tests doesn't tap on button.

@anku255 anku255 mentioned this pull request Aug 10, 2020
@anku255 anku255 closed this Aug 14, 2020
@anku255 anku255 deleted the new-alert-screen branch August 14, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final The PR that will be pointed to the facebook repo. Do not delete this branch. RNTester The issues associated with the RNTester project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants