Add tests for Alert API #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevakallio
reviewed
Jun 15, 2020
jevakallio
left a comment
jevakallio
left a comment
There was a problem hiding this comment.
@anku255 the code looks great! The test case naming could be improved somewhat. See my comment on another PR here, and if you agree with the approach, implement the same changes here?
jevakallio
approved these changes
Jun 16, 2020
jevakallio
left a comment
jevakallio
left a comment
There was a problem hiding this comment.
LGTM! Let's discuss tomorrow how we are going to land these, considering the new instructions we received from Rick to squash and merge these locally
jevakallio
added
the
pending merge
Member
Author
|
It is obsolete now because of #183. I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3
Changelog
Add e2e tests for Alert API.
[IOS] [Added] - e2e test for the Alert API
Test Plan
On running the following commands
You will get the following output -