Skip to content

fix: ensure Apps SDK adapter is bundled properly and initialized wth config #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
idosal merged 3 commits into from
Oct 25, 2025
Merged

fix: ensure Apps SDK adapter is bundled properly and initialized wth config #137

idosal merged 3 commits into from
Oct 25, 2025

Conversation

@gching
Copy link
Contributor

@gching gching commented Oct 24, 2025 •
edited
Loading

This PR fixes the Apps SDK adapter to be bundled properly and initialized with the correct config.

Problem

  • Bundled adapter-runtime.ts is an IIFE and therefore, the outer adapter.ts script does not have reference to initAdapter and uninstallAdapter
Screenshot 2025-10-24 at 3 21 45 AM
  • Previous code still worked since the IIFE adapter-runtime.ts itself ran and initialized, but with no config

Changes

  • The esbuild script now compiles the runtime into a standard, non-bundled ES module instead of an IIFE.
  • adapter-runtime.ts no longer auto-installs and acts as a library
  • adapter.ts calls initAdapter(...) if auto-init is enabled and properly references initAdapter
  • Adds in initWithConfig so user has flexibility to init with their own values or their provided server values

@gching gching force-pushed the gching/oai-fix-adapter-init branch from 11a23b1 to 4a38381 Compare October 24, 2025 10:40
@idosal idosal requested a review from Copilot October 24, 2025 20:48
Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Apps SDK adapter bundling and initialization issues. The adapter was previously built as an IIFE which prevented proper reference to its exported functions, and it auto-initialized without access to server-provided configuration.

Key changes:

  • Modified esbuild configuration to output ESM instead of IIFE format
  • Removed auto-initialization logic from adapter-runtime.ts
  • Added proper initialization with config in adapter.ts wrapper

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
sdks/typescript/server/scripts/bundle-adapter.js Changed build output from IIFE to ESM module format
sdks/typescript/server/src/adapters/appssdk/adapter-runtime.ts Removed auto-init logic and AdapterWindow type, made functions non-exported
sdks/typescript/server/src/adapters/appssdk/adapter.ts Added function existence check, conditional auto-init, and initWithConfig method
sdks/typescript/server/src/tests/adapters/appssdk-adapter.test.ts Updated test to verify initWithConfig instead of NO_AUTO_INSTALL flag

idosal
idosal reviewed Oct 24, 2025
View reviewed changes
@gching gching force-pushed the gching/oai-fix-adapter-init branch from 4844d67 to 000d325 Compare October 24, 2025 23:00
@gching gching requested a review from idosal October 25, 2025 05:43
idosal
idosal approved these changes Oct 25, 2025
View reviewed changes
Copy link
Collaborator

@idosal idosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gching Awesome. Thanks for the fix and your other contributions to MCP-UI and the open spec!

@idosal idosal changed the title Fix: Ensure Apps SDK adapter is bundled properly and initialized wth config fix: ensure Apps SDK adapter is bundled properly and initialized wth config Oct 25, 2025
@idosal idosal merged commit 4f7c25c into MCP-UI-Org:main Oct 25, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 25, 2025
@semantic-release-bot
chore(release): 5.13.1 [skip ci]\n\n## [5.13.1](server/v5.13.0...serv…
e623c6d 
…er/v5.13.1) (2025-10-25)

### Bug Fixes

* Enable bidirectional message relay in rawhtml proxy mode ([#138](#138)) ([f0bdefb](f0bdefb))
* ensure Apps SDK adapter is bundled properly and initialized wth config ([#137](#137)) ([4f7c25c](4f7c25c))
@gching gching deleted the gching/oai-fix-adapter-init branch October 25, 2025 18:47
github-actions bot pushed a commit that referenced this pull request Nov 4, 2025
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
dcda43e 
# 1.0.0 (2025-11-04)

### Bug Fixes

* add a bridge to pass messages in and out of the proxy ([#38](#38)) ([30ccac0](30ccac0))
* bump client version ([75c9236](75c9236))
* **client:** specify iframe ([fd0b70a](fd0b70a))
* **client:** styling ([6ff9b68](6ff9b68))
* dependencies ([887f61f](887f61f))
* Enable bidirectional message relay in rawhtml proxy mode ([#138](#138)) ([f0bdefb](f0bdefb))
* ensure Apps SDK adapter is bundled properly and initialized wth config ([#137](#137)) ([4f7c25c](4f7c25c))
* export RemoteDomResource ([2b86f2d](2b86f2d))
* export ResourceRenderer and HtmlResource ([2b841a5](2b841a5))
* exports ([3a93a16](3a93a16))
* fix file extension reference in package.json ([927989c](927989c))
* iframe handle ([#15](#15)) ([66bd4fd](66bd4fd))
* lint ([4487820](4487820))
* lint ([d0a91f9](d0a91f9))
* minor typo ([a0bee9c](a0bee9c))
* move react dependencies to be peer dependencies ([#91](#91)) ([f672f3e](f672f3e)), closes [#90](#90)
* package config ([8dc1e53](8dc1e53))
* packaging ([9e6babd](9e6babd))
* pass ref explicitly using iframeProps ([#33](#33)) ([d01b5d1](d01b5d1))
* publish ([0943e7a](0943e7a))
* ref passing to UIResourceRenderer ([#32](#32)) ([d28c23f](d28c23f))
* remove shared dependency ([e66e8f4](e66e8f4))
* rename components and methods to fit new scope ([#22](#22)) ([6bab1fe](6bab1fe))
* rename delivery -> encoding and flavor -> framework ([#36](#36)) ([9a509ed](9a509ed))
* Ruby comment ([b22dc2e](b22dc2e))
* support react-router ([21ffb95](21ffb95))
* text and blob support in RemoteDOM resources ([ec68eb9](ec68eb9))
* trigger release ([aaca831](aaca831))
* typescript ci publish ([e7c0ebf](e7c0ebf))
* typescript types to be compatible with MCP SDK ([#10](#10)) ([74365d7](74365d7))
* update deps ([4091ef4](4091ef4))
* update isUIResource to use EmbeddedResource type ([#122](#122)) ([5a65a0b](5a65a0b)), closes [#117](#117)
* use targetOrigin in the proxy message relay ([#40](#40)) ([b3fb54e](b3fb54e))
* validate URL ([b7c994d](b7c994d))
* wc dist overwrite ([#63](#63)) ([9e46c56](9e46c56))

### Documentation

* bump ([#4](#4)) ([ad4d163](ad4d163))

### Features

* add convenience function isUIResource to client SDK ([#86](#86)) ([607c6ad](607c6ad))
* add embeddedResourceProps for annotations ([#99](#99)) ([b96ec44](b96ec44))
* add proxy option to externalUrl ([#37](#37)) ([7b95cd0](7b95cd0))
* add remote-dom content type ([#18](#18)) ([5dacf37](5dacf37))
* add Ruby server SDK ([#31](#31)) ([5ffcde4](5ffcde4))
* add sandbox permissions instead of an override ([#83](#83)) ([b1068e9](b1068e9))
* add ui-request-render-data message type ([#111](#111)) ([26135ce](26135ce))
* add UIResourceRenderer Web Component ([#58](#58)) ([ec8f299](ec8f299))
* auto resize with the autoResizeIframe prop ([#56](#56)) ([76c867a](76c867a))
* change onGenericMcpAction to optional onUiAction ([1913b59](1913b59))
* **client:** allow setting supportedContentTypes for HtmlResource ([#17](#17)) ([e009ef1](e009ef1))
* consolidate ui:// and ui-app:// ([#8](#8)) ([2e08035](2e08035))
* pass iframe props down ([#14](#14)) ([112539d](112539d))
* refactor UTFtoB64 (bump server version) ([#95](#95)) ([2d5e16b](2d5e16b))
* send render data to the iframe ([#51](#51)) ([d38cfc7](d38cfc7))
* separate html and remote-dom props ([#24](#24)) ([a7f0529](a7f0529))
* support adapters ([#127](#127)) ([d4bd152](d4bd152))
* support generic messages response ([#35](#35)) ([10b407b](10b407b))
* support metadata in Python SDK ([#134](#134)) ([9bc3c64](9bc3c64))
* support passing resource metadata ([#87](#87)) ([f1c1c9b](f1c1c9b))
* support proxy for rawHtml ([#132](#132)) ([1bbeb09](1bbeb09))
* support ui action result types ([#6](#6)) ([899d152](899d152))
* switch to ResourceRenderer ([#21](#21)) ([6fe3166](6fe3166))

### BREAKING CHANGES

* The existing naming is ambiguous. Renaming delivery to encoding and flavor to framework should clarify the intent.
* exported names have changed
* removed deprecated client API
* (previous one didn't take due to semantic-release misalignment)
github-actions bot pushed a commit that referenced this pull request Nov 29, 2025
@semantic-release-bot
chore(release): 5.15.0 [skip ci]\n\n# [5.15.0](client/v5.14.1...clien…
6183bbe 
…t/v5.15.0) (2025-11-29)

### Bug Fixes

* ensure Apps SDK adapter is bundled properly and initialized wth config ([#137](#137)) ([4f7c25c](4f7c25c))

### Features

* support metadata in Python SDK ([#134](#134)) ([9bc3c64](9bc3c64))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@idosal idosal idosal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gching @idosal